[coreboot-gerrit] Change in coreboot[master]: mb/supermicro/x11-lga1151-series: add x11ssm-f board

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35427 )

Change subject: mb/supermicro/x11-lga1151-series: add x11ssm-f board
......................................................................

Patch Set 48:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35427/41/src/mainboard/supermicro/x... 
File src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/mainboard.c:

https://review.coreboot.org/c/coreboot/+/35427/41/src/mainboard/supermicro/x... 
PS41, Line 24: Find out why the polarities from gpio.h gets overwritten by FSP.
> Are you sure the final values, when coreboot is done differ from the `gpio.h` […]

Ok, I think, I got it. It's the jumping back and forth of intel/ code
that makes things too fragile. It seems the snapshot is taken before
the GPIO settings are written. Doing anything beyond filling parameters
in mainboard_silicon_init_params() seems like a bad idea.

IIRC, I even ended up applying GPIO settings only after silicon init
run on at least one board. Maybe it's time to make GPIO configuration
a clear step of the soc/ control flow?