Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44079 )
Change subject: mb/google/volteer/variant/lindar: Update gpio and devicetree settings
......................................................................
Patch Set 10:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44079/10/src/mainboard/google/volte...
File src/mainboard/google/volteer/variants/lindar/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/44079/10/src/mainboard/google/volte...
PS10, Line 60: register "generic.has_power_resource" = "1"
i think you still need to copy over the stop_gpio related config.
looks like it's the same GPP_E3 for lindar.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44079
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib869eef08433dab367edd46b3dc577190b6673d8
Gerrit-Change-Number: 44079
Gerrit-PatchSet: 10
Gerrit-Owner: Julia Tsai
julia.tsai@lcfc.corp-partner.google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Rasheed Hsueh
rasheed.hsueh@lcfc.corp-partner.google.com
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jerry2 Huang
jerry2.huang@lcfc.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 20 Aug 2020 08:21:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment