Attention is currently required from: Xi Chen, Hung-Te Lin, Christian Walter, Julius Werner.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69444 )
Change subject: treewide: stop calling custom TPM log "TCPA"
......................................................................
Patch Set 1:
(2 comments)
File src/include/memlayout.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163244):
https://review.coreboot.org/c/coreboot/+/69444/comment/26248ef8_3b7385f9
PS1, Line 171: #define TPM_LOG(addr, size) \
Macros with multiple statements should be enclosed in a do - while loop
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163244):
https://review.coreboot.org/c/coreboot/+/69444/comment/9d452adb_87222ede
PS1, Line 171: #define TPM_LOG(addr, size) \
macros should not use a trailing semicolon
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69444
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I896bd94f18b34d6c4b280f58b011d704df3d4022
Gerrit-Change-Number: 69444
Gerrit-PatchSet: 1
Gerrit-Owner: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Xi Chen
xixi.chen@mediatek.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Xi Chen
xixi.chen@mediatek.com
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Thu, 10 Nov 2022 22:35:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment