19 Nov
2021
19 Nov
'21
2:15 p.m.
Attention is currently required from: Karthik Ramasubramanian, Felix Held. Kangheui Won has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59449 )
Change subject: amdfwtool: clean up psp fw parsing ......................................................................
Patch Set 3:
(1 comment)
File util/amdfwtool/data_parse.c:
https://review.coreboot.org/c/coreboot/+/59449/comment/a8c7c2ea_d89410ec PS2, Line 110: psp_dir_valid_entries
If you can push a clean-up CL on top of this, I am fine. […]
That's totally reasonable, I just wanted to check that this kind of refactoring would be acceptable or not so uploaded minimal CL asap. I'll work on further refactoring and make CL chain here.
--
To view, visit https://review.coreboot.org/c/coreboot/+/59449
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id7adb20db7bab73933b457f3449b2d8ce4217b8c
Gerrit-Change-Number: 59449
Gerrit-PatchSet: 3
Gerrit-Owner: Kangheui Won khwon@chromium.org
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Bao Zheng fishbaozi@gmail.com
Gerrit-Attention: Karthik Ramasubramanian kramasub@google.com
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 19 Nov 2021 22:15:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kangheui Won khwon@chromium.org
Comment-In-Reply-To: Karthik Ramasubramanian kramasub@google.com
Gerrit-MessageType: comment