Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44280 )
Change subject: soc/intel/xeon_sp/cpx: add VT-d support
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44280/3/src/soc/intel/xeon_sp/cpx/c...
File src/soc/intel/xeon_sp/cpx/chip.h:
https://review.coreboot.org/c/coreboot/+/44280/3/src/soc/intel/xeon_sp/cpx/c...
PS3, Line 87: uint32_t coherency_support;
: uint32_t ats_support;
Removing these seems to be undesired: […]
I'd suggest removing these options from here and deltalake in its own commit, then add the VT-d options
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44280
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic66374af6e53fb847c1bdc324eb3f4e01c334a94
Gerrit-Change-Number: 44280
Gerrit-PatchSet: 3
Gerrit-Owner: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 11 Aug 2020 21:39:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment