Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31491 )
Change subject: console: Refactor printk() varargs prototypes
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/31491/3/src/console/printk.c
File src/console/printk.c:
https://review.coreboot.org/#/c/31491/3/src/console/printk.c@42
PS3, Line 42: static __inline
Wait why are we inlining this now? Doesn't that duplicate all this code?
inline is a hint. the compiler will do whatever it wants to do anyway.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31491
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I816641c2223c3079ad9c95c1380d4b250898ef93
Gerrit-Change-Number: 31491
Gerrit-PatchSet: 4
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 27 Feb 2019 11:09:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-MessageType: comment