Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34809 )
Change subject: arch/x86: Add postcar_frame_common_mtrrs()
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34809/2/src/arch/x86/postcar_loader...
File src/arch/x86/postcar_loader.c:
https://review.coreboot.org/c/coreboot/+/34809/2/src/arch/x86/postcar_loader...
PS2, Line 125: /* Cache RAM as WB from 0 -> CACHE_TMP_RAMTOP. */
Well currently we do. […]
I believe the final BSP MTRR's are already set up before the SIPI call. Besides does it even make much sense to want to cache the SIPI vector? The AP's MTRR's are not synced at that point or does it speed up setting up that stub?
Maybe this a vague remainder of non-relocatable ramstage?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34809
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id1f8b7682035e654231f6133a42909a36e3e15a1
Gerrit-Change-Number: 34809
Gerrit-PatchSet: 4
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Huang Jin
huang.jin@intel.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Lee Leahy
leroy.p.leahy@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Sat, 10 Aug 2019 10:59:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment