Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34835 )
Change subject: drivers/ipmi: make IPMI KCS status and command register spacing configurable ......................................................................
Patch Set 4:
(5 comments)
Patch Set 3:
(4 comments)
https://review.coreboot.org/c/coreboot/+/34835/2/src/drivers/ipmi/Kconfig File src/drivers/ipmi/Kconfig:
https://review.coreboot.org/c/coreboot/+/34835/2/src/drivers/ipmi/Kconfig@5 PS2, Line 5: choice
please remove the choice
Done
https://review.coreboot.org/c/coreboot/+/34835/2/src/drivers/ipmi/Kconfig@15 PS2, Line 15: bool "IPMI KCS register address offset 2 (WORD)"
Yes you are right, I will remove this part in my next patch set. […]
Done
https://review.coreboot.org/c/coreboot/+/34835/2/src/drivers/ipmi/Kconfig@26 PS2, Line 26: config KCS_REGISTER_OFFSET
The spec uses the name "spacing" instead of offset. I'd prefer IPMI_KCS_REGISTER_SPACING.
Done
https://review.coreboot.org/c/coreboot/+/34835/2/src/drivers/ipmi/Kconfig@28 PS2, Line 28: default 1 if KCS_REGISTER_OFFSET_1
default 1
Done
https://review.coreboot.org/c/coreboot/+/34835/2/src/drivers/ipmi/Kconfig@31 PS2, Line 31: depends on IPMI_KCS
in monolake mainboard Kconfig do: […]
Sure I will put this in another change.