Attention is currently required from: Arthur Heymans, Dinesh Gehlot, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Paul Menzel, Rishika Raj.
Subrata Banik has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/84080?usp=email )
Change subject: soc/intel/adl: Prevent unconditional legacy COM ports initialization ......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84080/comment/c2ad1721_9ec8ccb5?usp... : PS1, Line 18: As a result, this code is being removed and platforms that select : DRIVERS_UART_8250IO can activate legacy COM ports.
Are there boards, that need to be adapted?
Based on my understanding the boards that are expected to use Legacy COMs have already selected the correct Kconfig. For example: there are boards that select `DRIVERS_UART_8250IO` config. Ideally we don't need to keep legacy COMs default enabled.
``` src/mainboard/intel/adlrvp/Kconfig:25: select DRIVERS_UART_8250IO src/mainboard/intel/adlrvp/Kconfig:41: select DRIVERS_UART_8250IO src/mainboard/intel/adlrvp/Kconfig:70: select DRIVERS_UART_8250IO ```
https://review.coreboot.org/c/coreboot/+/84080/comment/047025e6_725d664d?usp... : PS1, Line 22: TEST=Able to boot google/redrix to OS.
How can it be checked, that no traffic goes over the IO bus?
eSPI protocol analysis is used to ensure there is no traffic over legacy COMs.