Furquan Shaikh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35881 )
Change subject: mb/google/octopus/variants/fleex: Update GPIOs to fix EMR ......................................................................
mb/google/octopus/variants/fleex: Update GPIOs to fix EMR
Update GPIO_138 and GPIO_139 setting to fix EMR function.
BUG=b:141729962,b:141281846 BRANCH=octopus TEST=verify EMR function in Grob360S.
Change-Id: I28cef592374fb4aeee2f3d3010cc0e237d62a2fd Signed-off-by: John Su john_su@compal.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/35881 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Marco Chen marcochen@google.com Reviewed-by: EricR Lai ericr_lai@compal.corp-partner.google.com Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net --- M src/mainboard/google/octopus/variants/fleex/gpio.c 1 file changed, 0 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Marco Chen: Looks good to me, approved EricR Lai: Looks good to me, approved
diff --git a/src/mainboard/google/octopus/variants/fleex/gpio.c b/src/mainboard/google/octopus/variants/fleex/gpio.c index a1e02d2..5924fa0 100644 --- a/src/mainboard/google/octopus/variants/fleex/gpio.c +++ b/src/mainboard/google/octopus/variants/fleex/gpio.c @@ -26,10 +26,6 @@ PAD_NC(GPIO_67, UP_20K), PAD_NC(GPIO_117, UP_20K),
- PAD_NC(GPIO_138, UP_20K), - PAD_NC(GPIO_139, UP_20K), - /* GPIO_140 -- PEN_RESET */ - PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_140, 0, DEEP, NONE, Tx1RxDCRx0, DISPUPD), PAD_NC(GPIO_143, UP_20K), PAD_NC(GPIO_144, UP_20K), PAD_NC(GPIO_145, UP_20K),