Attention is currently required from: Angel Pons, Patrick Rudolph.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61517 )
Change subject: [WIP]aopen/dxplplusu: Enable SMM_ASEG ......................................................................
Patch Set 3: Verified+1
(64 comments)
File src/southbridge/intel/i82801dx/smihandler.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162959): https://review.coreboot.org/c/coreboot/+/61517/comment/5328c8d0_15e2884e PS3, Line 45: if (pm1_sts & (1 << 15)) printk(BIOS_SPEW, "WAK "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162959): https://review.coreboot.org/c/coreboot/+/61517/comment/b5add4a5_31d9ff50 PS3, Line 46: if (pm1_sts & (1 << 14)) printk(BIOS_SPEW, "PCIEXPWAK "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162959): https://review.coreboot.org/c/coreboot/+/61517/comment/041b6468_38c79134 PS3, Line 47: if (pm1_sts & (1 << 11)) printk(BIOS_SPEW, "PRBTNOR "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162959): https://review.coreboot.org/c/coreboot/+/61517/comment/39278e27_d75083ae PS3, Line 48: if (pm1_sts & (1 << 10)) printk(BIOS_SPEW, "RTC "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162959): https://review.coreboot.org/c/coreboot/+/61517/comment/01cc3de5_52124678 PS3, Line 49: if (pm1_sts & (1 << 8)) printk(BIOS_SPEW, "PWRBTN "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162959): https://review.coreboot.org/c/coreboot/+/61517/comment/be01ed3f_7112ffd1 PS3, Line 50: if (pm1_sts & (1 << 5)) printk(BIOS_SPEW, "GBL "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162959): https://review.coreboot.org/c/coreboot/+/61517/comment/7c71ab53_5a3beb9d PS3, Line 51: if (pm1_sts & (1 << 4)) printk(BIOS_SPEW, "BM "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162959): https://review.coreboot.org/c/coreboot/+/61517/comment/b88ec2ab_a238e60b PS3, Line 52: if (pm1_sts & (1 << 0)) printk(BIOS_SPEW, "TMROF "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162959): https://review.coreboot.org/c/coreboot/+/61517/comment/9b782296_ea37dd57 PS3, Line 76: if (smi_sts & (1 << 26)) printk(BIOS_DEBUG, "SPI "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162959): https://review.coreboot.org/c/coreboot/+/61517/comment/4fddd599_db63b378 PS3, Line 77: if (smi_sts & (1 << 25)) printk(BIOS_DEBUG, "EL_SMI "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162959): https://review.coreboot.org/c/coreboot/+/61517/comment/4c0add94_7aac5db7 PS3, Line 78: if (smi_sts & (1 << 21)) printk(BIOS_DEBUG, "MONITOR "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162959): https://review.coreboot.org/c/coreboot/+/61517/comment/b769088c_fb256083 PS3, Line 79: if (smi_sts & (1 << 20)) printk(BIOS_DEBUG, "PCI_EXP_SMI "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162959): https://review.coreboot.org/c/coreboot/+/61517/comment/8e9af439_3b80c438 PS3, Line 80: if (smi_sts & (1 << 18)) printk(BIOS_DEBUG, "INTEL_USB2 "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162959): https://review.coreboot.org/c/coreboot/+/61517/comment/7d1f6967_a1c6576f PS3, Line 81: if (smi_sts & (1 << 17)) printk(BIOS_DEBUG, "LEGACY_USB2 "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162959): https://review.coreboot.org/c/coreboot/+/61517/comment/cb9b71c2_9bb915d0 PS3, Line 82: if (smi_sts & (1 << 16)) printk(BIOS_DEBUG, "SMBUS_SMI "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162959): https://review.coreboot.org/c/coreboot/+/61517/comment/210abca6_ac9391b7 PS3, Line 83: if (smi_sts & (1 << 15)) printk(BIOS_DEBUG, "SERIRQ_SMI "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162959): https://review.coreboot.org/c/coreboot/+/61517/comment/583c921c_f1b954c9 PS3, Line 84: if (smi_sts & (1 << 14)) printk(BIOS_DEBUG, "PERIODIC "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162959): https://review.coreboot.org/c/coreboot/+/61517/comment/3ac622c7_781057b1 PS3, Line 85: if (smi_sts & (1 << 13)) printk(BIOS_DEBUG, "TCO "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162959): https://review.coreboot.org/c/coreboot/+/61517/comment/03b2f310_aa11dbe3 PS3, Line 86: if (smi_sts & (1 << 12)) printk(BIOS_DEBUG, "DEVMON "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162959): https://review.coreboot.org/c/coreboot/+/61517/comment/a2b7d7d8_ac4b1d03 PS3, Line 87: if (smi_sts & (1 << 11)) printk(BIOS_DEBUG, "MCSMI "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162959): https://review.coreboot.org/c/coreboot/+/61517/comment/e189e8a1_91e505f0 PS3, Line 88: if (smi_sts & (1 << 10)) printk(BIOS_DEBUG, "GPI "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162959): https://review.coreboot.org/c/coreboot/+/61517/comment/cac1bdb7_3b0b28bc PS3, Line 89: if (smi_sts & (1 << 9)) printk(BIOS_DEBUG, "GPE0 "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162959): https://review.coreboot.org/c/coreboot/+/61517/comment/d632bed4_48747d7f PS3, Line 90: if (smi_sts & (1 << 8)) printk(BIOS_DEBUG, "PM1 "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162959): https://review.coreboot.org/c/coreboot/+/61517/comment/3b285f87_1e8362a2 PS3, Line 91: if (smi_sts & (1 << 6)) printk(BIOS_DEBUG, "SWSMI_TMR "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162959): https://review.coreboot.org/c/coreboot/+/61517/comment/a4033bbe_447bea62 PS3, Line 92: if (smi_sts & (1 << 5)) printk(BIOS_DEBUG, "APM "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162959): https://review.coreboot.org/c/coreboot/+/61517/comment/b9c197d2_5ffc9d56 PS3, Line 93: if (smi_sts & (1 << 4)) printk(BIOS_DEBUG, "SLP_SMI "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162959): https://review.coreboot.org/c/coreboot/+/61517/comment/63f1725c_fb13deab PS3, Line 94: if (smi_sts & (1 << 3)) printk(BIOS_DEBUG, "LEGACY_USB "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162959): https://review.coreboot.org/c/coreboot/+/61517/comment/edb15405_062d72a5 PS3, Line 95: if (smi_sts & (1 << 2)) printk(BIOS_DEBUG, "BIOS "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162959): https://review.coreboot.org/c/coreboot/+/61517/comment/011d617f_d556bb74 PS3, Line 118: for (i=31; i>= 16; i--) { spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162959): https://review.coreboot.org/c/coreboot/+/61517/comment/b94c1550_f771e884 PS3, Line 118: for (i=31; i>= 16; i--) { spaces required around that '>=' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162959): https://review.coreboot.org/c/coreboot/+/61517/comment/ab7cf284_c4c9a778 PS3, Line 119: if (gpe0_sts & (1 << i)) printk(BIOS_DEBUG, "GPIO%d ", (i-16)); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162959): https://review.coreboot.org/c/coreboot/+/61517/comment/58b9d6ec_2951d0d5 PS3, Line 121: if (gpe0_sts & (1 << 14)) printk(BIOS_DEBUG, "USB4 "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162959): https://review.coreboot.org/c/coreboot/+/61517/comment/dd0d9af9_de772ed4 PS3, Line 122: if (gpe0_sts & (1 << 13)) printk(BIOS_DEBUG, "PME_B0 "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162959): https://review.coreboot.org/c/coreboot/+/61517/comment/7bcfdbc4_fa19f63f PS3, Line 123: if (gpe0_sts & (1 << 12)) printk(BIOS_DEBUG, "USB3 "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162959): https://review.coreboot.org/c/coreboot/+/61517/comment/0159bdbb_069f9650 PS3, Line 124: if (gpe0_sts & (1 << 11)) printk(BIOS_DEBUG, "PME "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162959): https://review.coreboot.org/c/coreboot/+/61517/comment/26c00434_dc4e7da2 PS3, Line 125: if (gpe0_sts & (1 << 10)) printk(BIOS_DEBUG, "EL_SCI/BATLOW "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162959): https://review.coreboot.org/c/coreboot/+/61517/comment/1b8b8306_74c9c84a PS3, Line 126: if (gpe0_sts & (1 << 9)) printk(BIOS_DEBUG, "PCI_EXP "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162959): https://review.coreboot.org/c/coreboot/+/61517/comment/ecc1d21e_467ffd73 PS3, Line 127: if (gpe0_sts & (1 << 8)) printk(BIOS_DEBUG, "RI "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162959): https://review.coreboot.org/c/coreboot/+/61517/comment/3736f911_c268d487 PS3, Line 128: if (gpe0_sts & (1 << 7)) printk(BIOS_DEBUG, "SMB_WAK "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162959): https://review.coreboot.org/c/coreboot/+/61517/comment/c4a83778_56399e59 PS3, Line 129: if (gpe0_sts & (1 << 6)) printk(BIOS_DEBUG, "TCO_SCI "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162959): https://review.coreboot.org/c/coreboot/+/61517/comment/4c5cf163_ef4e366d PS3, Line 130: if (gpe0_sts & (1 << 5)) printk(BIOS_DEBUG, "AC97 "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162959): https://review.coreboot.org/c/coreboot/+/61517/comment/ace0d4ce_9aa1ade2 PS3, Line 131: if (gpe0_sts & (1 << 4)) printk(BIOS_DEBUG, "USB2 "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162959): https://review.coreboot.org/c/coreboot/+/61517/comment/44f6aa71_6c393466 PS3, Line 132: if (gpe0_sts & (1 << 3)) printk(BIOS_DEBUG, "USB1 "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162959): https://review.coreboot.org/c/coreboot/+/61517/comment/760d0995_a2e196df PS3, Line 133: if (gpe0_sts & (1 << 2)) printk(BIOS_DEBUG, "HOT_PLUG "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162959): https://review.coreboot.org/c/coreboot/+/61517/comment/1083e3c2_9dcdab75 PS3, Line 134: if (gpe0_sts & (1 << 0)) printk(BIOS_DEBUG, "THRM "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162959): https://review.coreboot.org/c/coreboot/+/61517/comment/6acf48bd_fd3e22f9 PS3, Line 159: if (tco_sts & (1 << 20)) printk(BIOS_DEBUG, "SMLINK_SLV "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162959): https://review.coreboot.org/c/coreboot/+/61517/comment/170f77a0_79a0e995 PS3, Line 160: if (tco_sts & (1 << 18)) printk(BIOS_DEBUG, "BOOT "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162959): https://review.coreboot.org/c/coreboot/+/61517/comment/ab1b2a8f_dae00753 PS3, Line 161: if (tco_sts & (1 << 17)) printk(BIOS_DEBUG, "SECOND_TO "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162959): https://review.coreboot.org/c/coreboot/+/61517/comment/e62b20a8_be9689d3 PS3, Line 162: if (tco_sts & (1 << 16)) printk(BIOS_DEBUG, "INTRD_DET "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162959): https://review.coreboot.org/c/coreboot/+/61517/comment/f66861b5_68f56584 PS3, Line 163: if (tco_sts & (1 << 12)) printk(BIOS_DEBUG, "DMISERR "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162959): https://review.coreboot.org/c/coreboot/+/61517/comment/8e440700_f5174272 PS3, Line 164: if (tco_sts & (1 << 10)) printk(BIOS_DEBUG, "DMISMI "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162959): https://review.coreboot.org/c/coreboot/+/61517/comment/25cb9757_26d74c7c PS3, Line 165: if (tco_sts & (1 << 9)) printk(BIOS_DEBUG, "DMISCI "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162959): https://review.coreboot.org/c/coreboot/+/61517/comment/95e7ef27_6084c5ae PS3, Line 166: if (tco_sts & (1 << 8)) printk(BIOS_DEBUG, "BIOSWR "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162959): https://review.coreboot.org/c/coreboot/+/61517/comment/ee9d9449_6fbb6f84 PS3, Line 167: if (tco_sts & (1 << 7)) printk(BIOS_DEBUG, "NEWCENTURY "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162959): https://review.coreboot.org/c/coreboot/+/61517/comment/63268a2c_9a41f91a PS3, Line 168: if (tco_sts & (1 << 3)) printk(BIOS_DEBUG, "TIMEOUT "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162959): https://review.coreboot.org/c/coreboot/+/61517/comment/b1c85263_f6ccb8a6 PS3, Line 169: if (tco_sts & (1 << 2)) printk(BIOS_DEBUG, "TCO_INT "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162959): https://review.coreboot.org/c/coreboot/+/61517/comment/649c1072_7f95fdf7 PS3, Line 170: if (tco_sts & (1 << 1)) printk(BIOS_DEBUG, "SW_TCO "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162959): https://review.coreboot.org/c/coreboot/+/61517/comment/754a312b_eab68289 PS3, Line 171: if (tco_sts & (1 << 0)) printk(BIOS_DEBUG, "NMI2SMI "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162959): https://review.coreboot.org/c/coreboot/+/61517/comment/374e4965_f6a87a8c PS3, Line 247: case ACPI_S0: printk(BIOS_DEBUG, "SMI#: Entering S0 (On)\n"); break; trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162959): https://review.coreboot.org/c/coreboot/+/61517/comment/c8baac4f_8de0319e PS3, Line 248: case ACPI_S1: printk(BIOS_DEBUG, "SMI#: Entering S1 (Assert STPCLK#)\n"); break; trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162959): https://review.coreboot.org/c/coreboot/+/61517/comment/8d3c405d_3dd94e11 PS3, Line 254: case ACPI_S4: printk(BIOS_DEBUG, "SMI#: Entering S4 (Suspend-To-Disk)\n"); break; trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162959): https://review.coreboot.org/c/coreboot/+/61517/comment/93b664b7_9c222860 PS3, Line 274: default: printk(BIOS_DEBUG, "SMI#: ERROR: SLP_TYP reserved\n"); break; trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162959): https://review.coreboot.org/c/coreboot/+/61517/comment/70cfca96_7fb1db4c PS3, Line 352: printk(BIOS_DEBUG, "GPI (mask %04x)\n",reg16); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162959): https://review.coreboot.org/c/coreboot/+/61517/comment/c9cfd0a9_6d9f09f8 PS3, Line 488: if (dump) { braces {} are not necessary for single statement blocks