30 Jun
2023
30 Jun
'23
5:46 p.m.
Attention is currently required from: Felix Held, Jason Glenesk, Matt DeVillier.
Fred Reitberger has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76162?usp=email )
Change subject: soc/amd/phoenix/Makefile.inc: Pass APOB_NV address as offset ......................................................................
Patch Set 3:
(1 comment)
File src/soc/amd/phoenix/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/76162/comment/e9a07ef0_249fd76c : PS2, Line 138: $(shell awk '$$2 == "FMAP_SECTION_FLASH_START" {print $$3}' $(obj)/fmap_config.h))
does it make sense to split this line out / save as a variable since it's being used twice (potentia […]
see followup (CB:76197)
--
To view, visit https://review.coreboot.org/c/coreboot/+/76162?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0f710f12cc5d933a75840dbce1c4bad0c2ea04cc
Gerrit-Change-Number: 76162
Gerrit-PatchSet: 3
Gerrit-Owner: Fred Reitberger reitbergerfred@gmail.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Reviewer: Matt DeVillier matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Attention: Matt DeVillier matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 30 Jun 2023 17:46:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier matt.devillier@amd.corp-partner.google.com
Gerrit-MessageType: comment