Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43866 )
Change subject: soc/intel/skylake: Enable HDA depending on devicetree configuration
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43866/2/src/soc/intel/skylake/chip....
File src/soc/intel/skylake/chip.c:
https://review.coreboot.org/c/coreboot/+/43866/2/src/soc/intel/skylake/chip....
PS2, Line 278: params->PchHdaVcType = config->PchHdaVcType;
: params->PchHdaIoBufferOwnership = config->IoBufferOwnership;
: params->PchHdaDspEnable = config->DspEnable;
:
oops, Device4Enable not, ofc
This change is not intended to change the logic of this code.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43866
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id20d023b2f286753fb223050292c7514632e1dd3
Gerrit-Change-Number: 43866
Gerrit-PatchSet: 5
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: Wim Vervoorn
wvervoorn@eltan.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Michael Niewöhner
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 29 Jul 2020 18:10:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michael Niewöhner
Gerrit-MessageType: comment