Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/85498?usp=email )
Change subject: mb/amb/birman*/gpio: remove configuration for VDD_MEM_VID[0,1] ......................................................................
mb/amb/birman*/gpio: remove configuration for VDD_MEM_VID[0,1]
Fix VDD_MEM_VID[0,1] pin assignments that was causing boot issues.
Change-Id: Ie5634575aff6dad210928c9c9af808e245322b99 Signed-off-by: Ana Carolina Cabral ana.cabral@amd.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/85498 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Felix Held felix-coreboot@felixheld.de --- M src/mainboard/amd/birman/gpio.c M src/mainboard/amd/birman_plus/gpio.c 2 files changed, 4 insertions(+), 8 deletions(-)
Approvals: Felix Held: Looks good to me, approved build bot (Jenkins): Verified
diff --git a/src/mainboard/amd/birman/gpio.c b/src/mainboard/amd/birman/gpio.c index 74d929d..348f76a 100644 --- a/src/mainboard/amd/birman/gpio.c +++ b/src/mainboard/amd/birman/gpio.c @@ -29,8 +29,7 @@ PAD_SCI(GPIO_8, PULL_UP, EDGE_LOW), /* SD_CARD_PRSNT_L */ PAD_GPI(GPIO_9, PULL_UP), /* Unclear if this needs to be SCI */ - /* VDD_MEM_VID0 */ - PAD_GPO(GPIO_10, HIGH), + /* GPIO_10: VDD_MEM_VID0 - Controlled by firmware outside of coreboot (ABL) */ /* HP_MIC_DET_L */ PAD_GPI(GPIO_11, PULL_UP), /* ALIGN_FLAG_MU_L */ @@ -76,8 +75,7 @@ /* USB2_HDR_P0/1_SMI */ PAD_SCI(GPIO_40, PULL_UP, EDGE_LOW), /* GPIO_41: Not available */ - /* VDD_MEM_VID1 */ - PAD_GPO(GPIO_42, HIGH), + /* GPIO_42: VDD_MEM_VID1 - Controlled by firmware outside of coreboot (ABL) */ /* GPIO_43 - GPIO_66: Not available */ /* SPI_ROM_REQ */ PAD_NF(GPIO_67, SPI_ROM_REQ, PULL_NONE), diff --git a/src/mainboard/amd/birman_plus/gpio.c b/src/mainboard/amd/birman_plus/gpio.c index 74d929d..348f76a 100644 --- a/src/mainboard/amd/birman_plus/gpio.c +++ b/src/mainboard/amd/birman_plus/gpio.c @@ -29,8 +29,7 @@ PAD_SCI(GPIO_8, PULL_UP, EDGE_LOW), /* SD_CARD_PRSNT_L */ PAD_GPI(GPIO_9, PULL_UP), /* Unclear if this needs to be SCI */ - /* VDD_MEM_VID0 */ - PAD_GPO(GPIO_10, HIGH), + /* GPIO_10: VDD_MEM_VID0 - Controlled by firmware outside of coreboot (ABL) */ /* HP_MIC_DET_L */ PAD_GPI(GPIO_11, PULL_UP), /* ALIGN_FLAG_MU_L */ @@ -76,8 +75,7 @@ /* USB2_HDR_P0/1_SMI */ PAD_SCI(GPIO_40, PULL_UP, EDGE_LOW), /* GPIO_41: Not available */ - /* VDD_MEM_VID1 */ - PAD_GPO(GPIO_42, HIGH), + /* GPIO_42: VDD_MEM_VID1 - Controlled by firmware outside of coreboot (ABL) */ /* GPIO_43 - GPIO_66: Not available */ /* SPI_ROM_REQ */ PAD_NF(GPIO_67, SPI_ROM_REQ, PULL_NONE),