Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30901 )
Change subject: soc/sifive/fu540: add support boot from sdcard
......................................................................
Patch Set 28:
(1 comment)
https://review.coreboot.org/#/c/30901/28/src/mainboard/sifive/hifive-unleash...
File src/mainboard/sifive/hifive-unleashed/media.c:
https://review.coreboot.org/#/c/30901/28/src/mainboard/sifive/hifive-unleash...
PS28, Line 35: static ssize_t unleashed_sd_readat(const struct region_device *rdev, void *dest,
that doesn't seem to be riscv specific. Should probably be moved to src/drivers/sdcard similar to src/drivers/spi/.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30901
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id97d293aee33082191cfaf47844769bdfa3d7a1b
Gerrit-Change-Number: 30901
Gerrit-PatchSet: 28
Gerrit-Owner: Xiang Wang
wxjstz@126.com
Gerrit-Reviewer: Jonathan Neuschäfer
j.neuschaefer@gmx.net
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: Shawn C
citypw@gmail.com
Gerrit-Reviewer: Xiang Wang
wxjstz@126.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 22 May 2019 07:07:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment