build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27036 )
Change subject: src: Get rid of device_t ......................................................................
Patch Set 1:
(11 comments)
https://review.coreboot.org/#/c/27036/1/src/northbridge/amd/amdmct/mct_ddr3/... File src/northbridge/amd/amdmct/mct_ddr3/s3utils.c:
https://review.coreboot.org/#/c/27036/1/src/northbridge/amd/amdmct/mct_ddr3/... PS1, Line 75: struct device *dev_fn1 = dev_find_slot(0, PCI_DEVFN(0x18 + node, 1)); line over 80 characters
https://review.coreboot.org/#/c/27036/1/src/northbridge/amd/amdmct/mct_ddr3/... PS1, Line 97: struct device *dev_fn1 = dev_find_slot(0, PCI_DEVFN(0x18 + node, 1)); line over 80 characters
https://review.coreboot.org/#/c/27036/1/src/northbridge/amd/amdmct/mct_ddr3/... PS1, Line 134: struct device *dev_fn1 = dev_find_slot(0, PCI_DEVFN(0x18 + node, 1)); line over 80 characters
https://review.coreboot.org/#/c/27036/1/src/northbridge/amd/amdmct/mct_ddr3/... PS1, Line 250: static uint32_t read_config32_dct_nbpstate(struct device *dev, uint8_t node, uint8_t dct, uint8_t nb_pstate, uint32_t reg) { line over 80 characters
https://review.coreboot.org/#/c/27036/1/src/northbridge/amd/amdmct/mct_ddr3/... PS1, Line 250: static uint32_t read_config32_dct_nbpstate(struct device *dev, uint8_t node, uint8_t dct, uint8_t nb_pstate, uint32_t reg) { open brace '{' following function declarations go on the next line
https://review.coreboot.org/#/c/27036/1/src/northbridge/amd/amdmct/mct_ddr3/... PS1, Line 315: struct device *dev_fn1 = dev_find_slot(0, PCI_DEVFN(0x18 + node, 1)); line over 80 characters
https://review.coreboot.org/#/c/27036/1/src/northbridge/amd/amdmct/mct_ddr3/... PS1, Line 316: struct device *dev_fn2 = dev_find_slot(0, PCI_DEVFN(0x18 + node, 2)); line over 80 characters
https://review.coreboot.org/#/c/27036/1/src/northbridge/amd/amdmct/mct_ddr3/... PS1, Line 317: struct device *dev_fn3 = dev_find_slot(0, PCI_DEVFN(0x18 + node, 3)); line over 80 characters
https://review.coreboot.org/#/c/27036/1/src/northbridge/amd/amdmct/mct_ddr3/... PS1, Line 527: static void write_config32_dct_nbpstate(pci_devfn_t dev, uint8_t node, uint8_t dct, uint8_t nb_pstate, uint32_t reg, uint32_t value) line over 80 characters
https://review.coreboot.org/#/c/27036/1/src/northbridge/amd/amdmct/mct_ddr3/... PS1, Line 547: static void write_amd_dct_index_register(pci_devfn_t dev, uint32_t index_ctl_reg, uint32_t index, uint32_t value) line over 80 characters
https://review.coreboot.org/#/c/27036/1/src/northbridge/amd/amdmct/mct_ddr3/... PS1, Line 559: static void write_amd_dct_index_register_dct(pci_devfn_t dev, uint8_t node, uint8_t dct, uint32_t index_ctl_reg, uint32_t index, uint32_t value) line over 80 characters