29 Dec
2021
29 Dec
'21
10:06 a.m.
Attention is currently required from: Julius Werner. Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60285 )
Change subject: mb/google/herobrine: Update GPIOs to Proto1 ......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/herobrine/mainboard.c:
https://review.coreboot.org/c/coreboot/+/60285/comment/bcd7629b_59e4700a PS1, Line 78: } else { /* BOARD_GOOGLE_HEROBRINE */
Oh, there you have it, okay. […]
Ok, sounds good. I though it would be more clear to split the rename and the new GPIOs, but if it's clear enough squashed I'll do that.
--
To view, visit https://review.coreboot.org/c/coreboot/+/60285
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iebf1d00a0ccbbc97a5bcb821a0ee1b6289e0a2ce
Gerrit-Change-Number: 60285
Gerrit-PatchSet: 1
Gerrit-Owner: Shelley Chen shchen@google.com
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com
Gerrit-CC: Sudheer Amrabadi samrabad@codeaurora.org
Gerrit-CC: mturney mturney mturney@codeaurora.org
Gerrit-Attention: Julius Werner jwerner@chromium.org
Gerrit-Comment-Date: Wed, 29 Dec 2021 18:06:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner jwerner@chromium.org
Gerrit-MessageType: comment