Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36086 )
Change subject: mb/google/hatch/akemi: disable unused devices for Akemi ......................................................................
Patch Set 3:
(5 comments)
https://review.coreboot.org/c/coreboot/+/36086/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36086/1//COMMIT_MSG@11 PS1, Line 11: close
Done
Done
https://review.coreboot.org/c/coreboot/+/36086/1//COMMIT_MSG@12 PS1, Line 12: GSPO
Done
Done
https://review.coreboot.org/c/coreboot/+/36086/1//COMMIT_MSG@12 PS1, Line 12: close
Done
Done
https://review.coreboot.org/c/coreboot/+/36086/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/akemi/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/36086/2/src/mainboard/google/hatch/... PS2, Line 6: [PchSerialIoIndexI2C2] = PchSerialIoPci, : [PchSerialIoIndexI2C3] = PchSerialIoPci,
if it is unused, I think it can set to PchSerialIoDisabled and set gpio to NC.
you are correct.
https://review.coreboot.org/c/coreboot/+/36086/2/src/mainboard/google/hatch/... PS2, Line 9: [PchSerialIoIndexI2C5] = PchSerialIoPci
if it is unused, I think it can set to PchSerialIoDisabled and set gpio to NC.
Done