Attention is currently required from: Hung-Te Lin, Paul Menzel, Xi Chen, Yidi Lin.
Yu-Ping Wu has posted comments on this change by Yidi Lin. ( https://review.coreboot.org/c/coreboot/+/83703?usp=email )
Change subject: soc/mediatek/common: Refactor EINT driver
......................................................................
Patch Set 4:
(1 comment)
File src/soc/mediatek/common/gpio.c:
https://review.coreboot.org/c/coreboot/+/83703/comment/7deb8cdb_d0afce78?usp... :
PS4, Line 124: mtk_eint = gpio_get_eint_reg(gpio);
assert not null. same below
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83703?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie53abc23971bfa39250ebd7dd48e28d6b91c5973
Gerrit-Change-Number: 83703
Gerrit-PatchSet: 4
Gerrit-Owner: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Xi Chen
xixi.chen@mediatek.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Xi Chen
xixi.chen@mediatek.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Comment-Date: Thu, 08 Aug 2024 08:04:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No