Marc Jones has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39987 )
Change subject: [WIP] mb/ocp/tiogapass: use ACPI to control GPIO
......................................................................
Patch Set 34:
I have some changes coming that might be helpful. This asl code should go in the xeon_sp/acpi/pch.asl. It isn't specific to the mainboard.
I plan to push changes tomorrow. I'll add you to the reviews.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39987
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0d4526c423b2192f51e515d993a05c03a3eaf58b
Gerrit-Change-Number: 39987
Gerrit-PatchSet: 34
Gerrit-Owner: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Marc Jones
marc@marcjonesconsulting.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 29 Sep 2020 05:15:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment