Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Patrick Rudolph, Karthik Ramasubramanian. Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57925 )
Change subject: drivers/intel/dptf: Add support for PCH methods ......................................................................
Patch Set 5:
(10 comments)
File src/drivers/intel/dptf/dptf.c:
https://review.coreboot.org/c/coreboot/+/57925/comment/a2d9f1b9_d3f5315a PS3, Line 228: acpigen_write_package(1); : acpigen_write_zero();
What is this change for?
Return a value for ESIF shell.
https://review.coreboot.org/c/coreboot/+/57925/comment/d8406531_b77cd3c3 PS3, Line 249: * Truncate Package recieved from IPC
'recieved' may be misspelled - perhaps 'received'? […]
Done
https://review.coreboot.org/c/coreboot/+/57925/comment/7b64d1af_241dce84 PS3, Line 282: 0x8
`PMC_IPC_COMMAND_FIVR_SIZE` […]
Ack
File src/drivers/intel/dptf/dptf.c:
https://review.coreboot.org/c/coreboot/+/57925/comment/744dd513_644b4eaa PS4, Line 349: .method_name = platform_info->tpch_method_names.get_fivr_switching_freq_mhz,
line over 96 characters
Please fix.
https://review.coreboot.org/c/coreboot/+/57925/comment/19598838_df6e1a03 PS4, Line 356: write_pkgc_method();
This only need to be written one time, correct? […]
This is required only for READ methods, not required for WRITE. So, I kept inside if(...), not before this for loop.
https://review.coreboot.org/c/coreboot/+/57925/comment/e630815a_6383a4b9 PS4, Line 358:
nit: line up with `tcph_methods`
Done
https://review.coreboot.org/c/coreboot/+/57925/comment/516db7bc_1fa2a0ca PS4, Line 358: tpch_methods[i].subcommand);
line over 96 characters
Please fix.
https://review.coreboot.org/c/coreboot/+/57925/comment/f0374f80_e9d2fb66 PS4, Line 360: else if (tpch_methods[i].type == WRITE)
else should follow close brace '}'
Please fix.
https://review.coreboot.org/c/coreboot/+/57925/comment/e6ffca23_40cb4e6a PS4, Line 362:
nit: line up with `tcph_methods`
Done
https://review.coreboot.org/c/coreboot/+/57925/comment/b20012a0_c1eff2f5 PS4, Line 362: tpch_methods[i].subcommand);
line over 96 characters
Please fix.