Attention is currently required from: Julius Werner.
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60284 )
Change subject: mb/google/herobrine: Transition BOARD_HEROBRINE to BOARD_HEROBRINE_REV0
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60284/comment/5ee118e5_ca78cdde
PS1, Line 7: _PROTO0
Remember to only refer to build stages by revision number (i.e. […]
Done
File src/mainboard/google/herobrine/mainboard.c:
https://review.coreboot.org/c/coreboot/+/60284/comment/20bdb753_6ec293c3
PS1, Line 78: }
Shouldn't we add a new BOARD_GOOGLE_HEROBRINE case now? (In general I think code should always be wr […]
Squashed GPIO patch into this patch to avoid confusion.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60284
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I67a0b282710031b927ce9022c7c535bd8d4ca1aa
Gerrit-Change-Number: 60284
Gerrit-PatchSet: 2
Gerrit-Owner: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Ravi Kumar Bokka
c_rbokka@qualcomm.corp-partner.google.com
Gerrit-CC: Sudheer Amrabadi
samrabad@codeaurora.org
Gerrit-CC: mturney mturney
mturney@codeaurora.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Wed, 29 Dec 2021 18:27:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment