Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/19956 )
Change subject: google/rambi: disable PCI device for unused i2c buses ......................................................................
google/rambi: disable PCI device for unused i2c buses
Light sensor isn't used and ACPI already removed, so disable I2C5 bus interface as well. Disable I2C6 for devices without a touchscreen
Change-Id: Ib0e041ae9131615ef1140bad064de5aae91f8ee4 Signed-off-by: Matt DeVillier matt.devillier@gmail.com Reviewed-on: https://review.coreboot.org/19956 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Martin Roth martinroth@google.com --- M src/mainboard/google/rambi/variants/clapper/devicetree.cb M src/mainboard/google/rambi/variants/enguarde/devicetree.cb M src/mainboard/google/rambi/variants/glimmer/devicetree.cb M src/mainboard/google/rambi/variants/gnawty/devicetree.cb M src/mainboard/google/rambi/variants/heli/devicetree.cb M src/mainboard/google/rambi/variants/kip/devicetree.cb M src/mainboard/google/rambi/variants/ninja/devicetree.cb M src/mainboard/google/rambi/variants/quawks/devicetree.cb M src/mainboard/google/rambi/variants/rambi/devicetree.cb M src/mainboard/google/rambi/variants/squawks/devicetree.cb M src/mainboard/google/rambi/variants/swanky/devicetree.cb 11 files changed, 15 insertions(+), 15 deletions(-)
Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved
diff --git a/src/mainboard/google/rambi/variants/clapper/devicetree.cb b/src/mainboard/google/rambi/variants/clapper/devicetree.cb index a95ddd1..13902b0 100644 --- a/src/mainboard/google/rambi/variants/clapper/devicetree.cb +++ b/src/mainboard/google/rambi/variants/clapper/devicetree.cb @@ -59,7 +59,7 @@ device pci 18.2 on end # I2C2 device pci 18.3 off end # I2C3 device pci 18.4 off end # I2C4 - device pci 18.5 on end # I2C5 + device pci 18.5 off end # I2C5 device pci 18.6 on end # I2C6 device pci 18.7 off end # I2C7 device pci 1a.0 on end # TXE diff --git a/src/mainboard/google/rambi/variants/enguarde/devicetree.cb b/src/mainboard/google/rambi/variants/enguarde/devicetree.cb index f3792fe..89929b0 100644 --- a/src/mainboard/google/rambi/variants/enguarde/devicetree.cb +++ b/src/mainboard/google/rambi/variants/enguarde/devicetree.cb @@ -71,8 +71,8 @@ device pci 18.2 on end # I2C2 device pci 18.3 off end # I2C3 device pci 18.4 off end # I2C4 - device pci 18.5 on end # I2C5 - device pci 18.6 off end # I2C6 + device pci 18.5 off end # I2C5 + device pci 18.6 off end # I2C6 device pci 18.7 off end # I2C7 device pci 1a.0 on end # TXE device pci 1b.0 on end # HDA diff --git a/src/mainboard/google/rambi/variants/glimmer/devicetree.cb b/src/mainboard/google/rambi/variants/glimmer/devicetree.cb index bf01cd9..5148225 100644 --- a/src/mainboard/google/rambi/variants/glimmer/devicetree.cb +++ b/src/mainboard/google/rambi/variants/glimmer/devicetree.cb @@ -68,7 +68,7 @@ device pci 18.2 on end # I2C2 device pci 18.3 off end # I2C3 device pci 18.4 off end # I2C4 - device pci 18.5 on end # I2C5 + device pci 18.5 off end # I2C5 device pci 18.6 on end # I2C6 device pci 18.7 off end # I2C7 device pci 1a.0 on end # TXE diff --git a/src/mainboard/google/rambi/variants/gnawty/devicetree.cb b/src/mainboard/google/rambi/variants/gnawty/devicetree.cb index bb6fcad..0024679 100644 --- a/src/mainboard/google/rambi/variants/gnawty/devicetree.cb +++ b/src/mainboard/google/rambi/variants/gnawty/devicetree.cb @@ -71,8 +71,8 @@ device pci 18.2 on end # I2C2 device pci 18.3 off end # I2C3 device pci 18.4 off end # I2C4 - device pci 18.5 on end # I2C5 - device pci 18.6 on end # I2C6 + device pci 18.5 off end # I2C5 + device pci 18.6 off end # I2C6 device pci 18.7 off end # I2C7 device pci 1a.0 on end # TXE device pci 1b.0 on end # HDA diff --git a/src/mainboard/google/rambi/variants/heli/devicetree.cb b/src/mainboard/google/rambi/variants/heli/devicetree.cb index d9b27e6..8b3c83f 100644 --- a/src/mainboard/google/rambi/variants/heli/devicetree.cb +++ b/src/mainboard/google/rambi/variants/heli/devicetree.cb @@ -72,8 +72,8 @@ device pci 18.2 on end # I2C2 device pci 18.3 off end # I2C3 device pci 18.4 off end # I2C4 - device pci 18.5 off end # I2C5 - device pci 18.6 off end # I2C6 + device pci 18.5 off end # I2C5 + device pci 18.6 off end # I2C6 device pci 18.7 off end # I2C7 device pci 1a.0 on end # TXE device pci 1b.0 on end # HDA diff --git a/src/mainboard/google/rambi/variants/kip/devicetree.cb b/src/mainboard/google/rambi/variants/kip/devicetree.cb index f4e0a91..d1d6beb 100644 --- a/src/mainboard/google/rambi/variants/kip/devicetree.cb +++ b/src/mainboard/google/rambi/variants/kip/devicetree.cb @@ -71,7 +71,7 @@ device pci 18.2 on end # I2C2 device pci 18.3 off end # I2C3 device pci 18.4 off end # I2C4 - device pci 18.5 on end # I2C5 + device pci 18.5 off end # I2C5 device pci 18.6 off end # I2C6 device pci 18.7 off end # I2C7 device pci 1a.0 on end # TXE diff --git a/src/mainboard/google/rambi/variants/ninja/devicetree.cb b/src/mainboard/google/rambi/variants/ninja/devicetree.cb index 6d56130..5c9595c 100644 --- a/src/mainboard/google/rambi/variants/ninja/devicetree.cb +++ b/src/mainboard/google/rambi/variants/ninja/devicetree.cb @@ -73,7 +73,7 @@ device pci 18.3 off end # I2C3 device pci 18.4 off end # I2C4 device pci 18.5 off end # I2C5 - device pci 18.6 off end # I2C6 + device pci 18.6 off end # I2C6 device pci 18.7 off end # I2C7 device pci 1a.0 on end # TXE device pci 1b.0 on end # HDA diff --git a/src/mainboard/google/rambi/variants/quawks/devicetree.cb b/src/mainboard/google/rambi/variants/quawks/devicetree.cb index cc5146d..320b59b 100644 --- a/src/mainboard/google/rambi/variants/quawks/devicetree.cb +++ b/src/mainboard/google/rambi/variants/quawks/devicetree.cb @@ -68,7 +68,7 @@ device pci 18.2 on end # I2C2 device pci 18.3 off end # I2C3 device pci 18.4 off end # I2C4 - device pci 18.5 on end # I2C5 + device pci 18.5 off end # I2C5 device pci 18.6 off end # I2C6 device pci 18.7 off end # I2C7 device pci 1a.0 on end # TXE diff --git a/src/mainboard/google/rambi/variants/rambi/devicetree.cb b/src/mainboard/google/rambi/variants/rambi/devicetree.cb index 5914a62..ddd1914 100644 --- a/src/mainboard/google/rambi/variants/rambi/devicetree.cb +++ b/src/mainboard/google/rambi/variants/rambi/devicetree.cb @@ -72,7 +72,7 @@ device pci 18.2 on end # I2C2 device pci 18.3 off end # I2C3 device pci 18.4 off end # I2C4 - device pci 18.5 on end # I2C5 + device pci 18.5 off end # I2C5 device pci 18.6 on end # I2C6 device pci 18.7 off end # I2C7 device pci 1a.0 on end # TXE diff --git a/src/mainboard/google/rambi/variants/squawks/devicetree.cb b/src/mainboard/google/rambi/variants/squawks/devicetree.cb index 400a551..26a915d 100644 --- a/src/mainboard/google/rambi/variants/squawks/devicetree.cb +++ b/src/mainboard/google/rambi/variants/squawks/devicetree.cb @@ -68,7 +68,7 @@ device pci 18.2 on end # I2C2 device pci 18.3 off end # I2C3 device pci 18.4 off end # I2C4 - device pci 18.5 on end # I2C5 + device pci 18.5 off end # I2C5 device pci 18.6 off end # I2C6 device pci 18.7 off end # I2C7 device pci 1a.0 on end # TXE diff --git a/src/mainboard/google/rambi/variants/swanky/devicetree.cb b/src/mainboard/google/rambi/variants/swanky/devicetree.cb index 5e78a10..db21bd6 100644 --- a/src/mainboard/google/rambi/variants/swanky/devicetree.cb +++ b/src/mainboard/google/rambi/variants/swanky/devicetree.cb @@ -71,8 +71,8 @@ device pci 18.2 on end # I2C2 device pci 18.3 off end # I2C3 device pci 18.4 off end # I2C4 - device pci 18.5 on end # I2C5 - device pci 18.6 on end # I2C6 + device pci 18.5 off end # I2C5 + device pci 18.6 off end # I2C6 device pci 18.7 off end # I2C7 device pci 1a.0 on end # TXE device pci 1b.0 on end # HDA