Attention is currently required from: Furquan Shaikh, Jack Rosenthal. Ricardo Quesada has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56883 )
Change subject: elogtool: add "clear" command ......................................................................
Patch Set 1:
(2 comments)
Patchset:
PS1: Hi Jack & Furquan, could you PTAL?
File src/commonlib/bsd/elog.c:
https://review.coreboot.org/c/coreboot/+/56883/comment/ce5ad4e7_7186f8a0 PS1, Line 50: static inline uint8_t mybin2bcd(uint8_t val) : { : return ((val / 10) << 4) | (val % 10); : } : Already defined here: https://github.com/coreboot/coreboot/blob/master/src/include/bcd.h
But licenced under GPL.
Should I rewrite it from scratch and license it under BSD? (or perhaps just copy it from Mosys which is BSD-based)
https://chromium.googlesource.com/chromiumos/platform/mosys/+/refs/heads/mai...
... and of course, change existing code to use the new include file?