[coreboot-gerrit] Change in coreboot[master]: soc/amd/picasso: Don't run dcache_clean_all() in psp_verstage

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43678 )

Change subject: soc/amd/picasso: Don't run dcache_clean_all() in psp_verstage
......................................................................

Patch Set 6:
> Patch Set 5:
> > Patch Set 5:
> > > Patch Set 5:
> > >
> > > I don't understand the arguments against overriding
> > > dcache_clean_all(). If a weak function isn't the way to
> > > go (I also see it like that), one can still use other
> > > mechanisms (weak functions mostly just spare us the
> > > addition of a Kconfig symbol).
> > >
> > > Alternatively, we could just guard the call to it. Either
> > > way, we have `rules.h` do advertise properties of the
> > > environment. Why not add an ENV_USER_SPACE and then
> > > don't try to clear caches if it's set?
> >
> > I was going to follow up with this notion so it's clearer what semantics we're trying to convey.
>
> Sorry Aaron, follow up with which notion?  Nico mentions two different ideas here.

In the hope that I can get something merged this week, I've pushed a competing patch train to https://review.coreboot.org/c/coreboot/+/43784