Attention is currently required from: Jérémy Compostella, yuchi.chen@intel.com.
Shuo Liu has posted comments on this change by yuchi.chen@intel.com. ( https://review.coreboot.org/c/coreboot/+/83316?usp=email )
Change subject: soc/intel/common/block/gpio/gpio.c: improve GPIO debug infos
......................................................................
Patch Set 6:
(1 comment)
File src/soc/intel/common/block/gpio/gpio.c:
https://review.coreboot.org/c/coreboot/+/83316/comment/b528ff54_573ac7eb?usp... :
PS6, Line 196: printk(BIOS_DEBUG, "GPE_EN[0x%02x, %02zu]: Reg: 0x%x, Value = 0x%08x\n",
Why we need 'zu'? Is it a must for size_t?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83316?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I8820956f6db91c7bcc26b46a4361da3dfa8f77b5
Gerrit-Change-Number: 83316
Gerrit-PatchSet: 6
Gerrit-Owner: yuchi.chen@intel.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: yuchi.chen@intel.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Comment-Date: Wed, 17 Jul 2024 10:53:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No