Attention is currently required from: Tim Wawrzynczak, Paul Menzel. Ben Chuang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59429 )
Change subject: drivers/genesyslogic/gl9750: Add driver for Genesys Logic GL9750 ......................................................................
Patch Set 2:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59429/comment/2e85bfdb_032f9898 PS1, Line 14:
could you add […]
Yes, done.
File src/drivers/genesyslogic/gl9750/gl9750.c:
https://review.coreboot.org/c/coreboot/+/59429/comment/a667d851_7474964a PS1, Line 7: #include <device/path.h>
unused?
Yes, Unused, thank you. The unused variable 'reg' has also been deleted.
https://review.coreboot.org/c/coreboot/+/59429/comment/64f28208_b692ccd0 PS1, Line 22: /* Disable ASPM L0s support */
Please add a comment, why this needs to be disabled.
Done
File src/include/device/pci_ids.h:
https://review.coreboot.org/c/coreboot/+/59429/comment/aaaba985_794e72df PS1, Line 2069: #define PCI_DEVICE_ID_GLI_9750 0x9750
Please sort the list.
Done