Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Jianeng Ceng, Kapil Porwal, Nick Vaccaro, Rishika Raj, Shou-Chieh Hsu, Subrata Banik.
Simon Yang has posted comments on this change by Simon Yang. ( https://review.coreboot.org/c/coreboot/+/84098?usp=email )
Change subject: mb/google/nissa/var/anraggar: Force audio mute to avoid screen flick
......................................................................
Patch Set 8:
(4 comments)
File src/mainboard/google/brya/variants/anraggar/variant.c:
https://review.coreboot.org/c/coreboot/+/84098/comment/e7e8a007_fc1d06fc?usp... :
PS7, Line 13: TRANS_DDI_AUDIO_MUTE_OVERRIDE_MASK
u don't need this anymore
I just don't think they are the same meaning so keep it.
https://review.coreboot.org/c/coreboot/+/84098/comment/0909a9f3_e5ec0f82?usp... :
PS7, Line 14: TRANS_DDI_AUDIO_MUTE_OVERRIDE_AND_SET
can you please rename this now […]
Done
https://review.coreboot.org/c/coreboot/+/84098/comment/2729e8b4_1d3dfa19?usp... :
PS7, Line 57: TRANS_DDI_AUDIO_MUTE_OVERRIDE_MASK
TRANS_DDI_AUDIO_MUTE_OVERRIDE_BITS_FIELDS
Done
https://review.coreboot.org/c/coreboot/+/84098/comment/92061ef9_432dedfd?usp... :
PS7, Line 58: TRANS_DDI_AUDIO_MUTE_OVERRIDE_AND_SET
TRANS_DDI_AUDIO_MUTE_OVERRIDE_BITS_FIELDS
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84098?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I711dfd0803440e4b04f02849fed529c3872e023d
Gerrit-Change-Number: 84098
Gerrit-PatchSet: 8
Gerrit-Owner: Simon Yang
simon1.yang@intel.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Jianeng Ceng
cengjianeng@huaqin.corp-partner.google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Rishika Raj
rishikaraj@google.com
Gerrit-Reviewer: Shou-Chieh Hsu
shouchieh@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Rishika Raj
rishikaraj@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Shou-Chieh Hsu
shouchieh@google.com
Gerrit-Attention: Jianeng Ceng
cengjianeng@huaqin.corp-partner.google.com
Gerrit-Comment-Date: Tue, 27 Aug 2024 15:57:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com