Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39104 )
Change subject: [WIP] mb/asrock/h110m: add libgfxinit support ......................................................................
Patch Set 13:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39104/13//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39104/13//COMMIT_MSG@14 PS13, Line 14: - EDP_TXN[2] -> EDP_VGA_TX0# : - EDP_TXN[3] -> EDP_VGA_TX1# : - EDP_TXP[2] -> EDP_VGA_TX0 : - EDP_TXP[2] -> EDP_VGA_TX1 Where does this come from?
https://review.coreboot.org/c/coreboot/+/39104/13/src/mainboard/asrock/h110m... File src/mainboard/asrock/h110m/gma-mainboard.ads:
https://review.coreboot.org/c/coreboot/+/39104/13/src/mainboard/asrock/h110m... PS13, Line 12: (DP2, -- DVI (DDI2) : HDMI3, -- HDMI (DDI3) : eDP, -- eDP->VGA (PTN3356R1BS) : others => Disabled); On SKL/KBL-S there are three DDIs plus one eDP port. Two of these DDIs are used for HDMI/DVI, and either the third DDI or eDP is wired to the DP-to-VGA converter. There should be two HDMIx entries and either one DPx or eDP.