William Wei has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42246 )
Change subject: mb/google/volteer/malefor: Update overridetree.cb
......................................................................
Patch Set 1:
(1 comment)
Patch Set 1:
(1 comment)
i see you're adding support for multiple audio DBs.
is that just copy-paste from volteer or is that intended
for malefor?
You're right, I copied volteer audio solution and removed "drivers/intel/soundwire". Malefor doesn't use max98373, I'll submit a new patchset to remove all the max98373 driver.
https://review.coreboot.org/c/coreboot/+/42246/1/src/mainboard/google/voltee...
File src/mainboard/google/volteer/variants/malefor/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/42246/1/src/mainboard/google/voltee...
PS1, Line 99: MAX98357_ALC5682I_I2S
is the max98360 software compatible with the max98357? there's no i2c interface, […]
Yes, max98360 and max98357 share the same driver, details please refer to below CR(https://partnerissuetracker.corp.google.com/issues/144298581%EF%BC%89
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42246
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9ce465705e8b8f67ddbc9e4eb06c5a8bfac65fcb
Gerrit-Change-Number: 42246
Gerrit-PatchSet: 1
Gerrit-Owner: William Wei
wenxu.wei@bitland.corp-partner.google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Alex Levin
levinale@google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: William Wei
wenxu.wei@bitland.corp-partner.google.com
Gerrit-Reviewer: Zhuohao Lee
zhuohao@chromium.org
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Hao He
hao.he@bitland.corp-partner.google.com
Gerrit-CC: Magf -
magf@bitland.corp-partner.google.com
Gerrit-CC: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-CC: Xiong Huang
xiong.huang@bitland.corp-partner.google.com
Gerrit-Comment-Date: Fri, 12 Jun 2020 01:49:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Caveh Jalali
caveh@chromium.org
Gerrit-MessageType: comment