Attention is currently required from: Jason Nien, Jon Murphy, Martin Roth, Tim Van Patten, Mark Hasemeyer.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74592 )
Change subject: mb/google/skyrim: Add named GPIO's
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74592/comment/b7e6d124_ee7b5306
PS2, Line 9: Add named GPIO's to help prevent confusion in GPIO management
I'm not sure I agree with making this type of change for Skyrim this late in the program, since we h […]
We can do a TIMELESS build and compare the binaries. If they are binary equivalent then the change should be fine.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74592
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If907478442ea7acb80b2e413926d173d188ce340
Gerrit-Change-Number: 74592
Gerrit-PatchSet: 2
Gerrit-Owner: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Mark Hasemeyer
markhas@google.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Attention: Jon Murphy
jpmurphy@google.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Tim Van Patten
timvp@google.com
Gerrit-Attention: Mark Hasemeyer
markhas@google.com
Gerrit-Comment-Date: Fri, 21 Apr 2023 14:51:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Van Patten
timvp@google.com
Gerrit-MessageType: comment