Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34587 )
Change subject: soc/*: mp_init: Remove configurable timeout
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34587/5/src/include/cpu/x86/mp.h
File src/include/cpu/x86/mp.h:
https://review.coreboot.org/c/coreboot/+/34587/5/src/include/cpu/x86/mp.h@13...
PS5, Line 137: long expire_us
Is it intentional that mp_run_on_aps still has the timeout but mp_run_on_all_cpus does not?
Yes. It's used by agesa wrapper and fsp2.0 mp init ppi, providing their own custom timeout.
I don't want to touch those black-boxes.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34587
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I456be647b159f7a2ea7d94986a24424e56dcc8c4
Gerrit-Change-Number: 34587
Gerrit-PatchSet: 5
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 31 Jul 2019 06:41:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment