Attention is currently required from: Hung-Te Lin, Paul Menzel. Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62893 )
Change subject: mb/google/corsola: Revise power-on sequence of PS8640 ......................................................................
Patch Set 7:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62893/comment/f5003a32_075f29a9 PS5, Line 9: The power-on sequence of PS8640 needs to be modified because the : waveform of power-on sequence do not meet the spec of PS8640.
Could you clarify that in the commit message? […]
Done
File src/mainboard/google/corsola/display.c:
https://review.coreboot.org/c/coreboot/+/62893/comment/b10b485e_b65d7964 PS6, Line 32: mdelay(55);
As no problems are known, I’d use 50 ms and not add a margin.
This patch is verified and it looks good from waveform. I think I still prefer to use 55ms. After all, it does not matter the boot time requirements of Chrome OS