Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33397 )
Change subject: util/amdfwtool: Align PSP NVRAM
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/#/c/33397/1/util/amdfwtool/amdfwtool.c
File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/#/c/33397/1/util/amdfwtool/amdfwtool.c@479
PS1, Line 479: (uint32_t)bytes;
Should this be rounded up to fill the entire 4k flash sector?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33397
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6b28525624b95b411cc82de0cbe430ea7871149d
Gerrit-Change-Number: 33397
Gerrit-PatchSet: 1
Gerrit-Owner: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 11 Jun 2019 18:06:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment