Attention is currently required from: Andrey Petrov. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63007 )
Change subject: drivers/intel/fsp2_0: Add native implementation for FSP Debug Handler ......................................................................
Patch Set 1:
(2 comments)
File src/drivers/intel/fsp2_0/fsp_debug_event.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144491): https://review.coreboot.org/c/coreboot/+/63007/comment/afaa36bd_b432d87d PS1, Line 24: if (!fsp_guid_compare ((uint8_t *)&(data->Type), fsp_string_type_guid)) space prohibited between function name and open parenthesis '('
File src/drivers/intel/fsp2_0/memory_init.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144491): https://review.coreboot.org/c/coreboot/+/63007/comment/d2114d45_518a80d0 PS1, Line 185: arch_upd->FspEventHandler = (UINT32)((FSP_EVENT_HANDLER *)fsp_debug_event_handler); line over 96 characters