Attention is currently required from: Jason Glenesk, Matt DeVillier, Fred Reitberger, Felix Held.
Hello build bot (Jenkins), Jason Glenesk, Matt DeVillier, Fred Reitberger,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/72860
to look at the new patch set (#5).
Change subject: soc/amd/picasso/soc_util: use cpuid_match ......................................................................
soc/amd/picasso/soc_util: use cpuid_match
Now that there is a cpuid_match function, we can use it instead of doing basically the same thing manually. In the functions is_fam17_1x and is_fam17_2x both the stepping number and the lower nibble of the model number are masked out. To avoid having magic constants in the code, introduce the CPUID_ALL_STEPPINGS_AND_BASE_MODELS_MASK definition.
Signed-off-by: Felix Held felix-coreboot@felixheld.de Change-Id: I758f9564c08c62c747cc4f93a8d6b540a1834a62 --- M src/arch/x86/include/arch/cpu.h M src/soc/amd/picasso/soc_util.c 2 files changed, 26 insertions(+), 12 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/72860/5