Attention is currently required from: Bao Zheng, Jason Glenesk, Martin L Roth, Marshall Dawson, Zheng Bao.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51881 )
Change subject: amdfwtool: Add a function to make the calling stack less deep
......................................................................
Patch Set 2:
(1 comment)
File util/amdfwtool/data_parse.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163584):
https://review.coreboot.org/c/coreboot/+/51881/comment/b53980dd_95e26070
PS2, Line 598: &(oneline[match[2].rm_so]), ch_lvl, dir, print_deps, cb_config);
line length of 104 exceeds 96 columns
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51881
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib8cae386eace4f423bde9c252992625e1ff3c690
Gerrit-Change-Number: 51881
Gerrit-PatchSet: 2
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Bao Zheng
fishbaozi@gmail.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Zheng Bao
Gerrit-Comment-Date: Mon, 14 Nov 2022 06:15:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment