Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42976 )
Change subject: Configs: Set PCH power policy register to S5
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42976/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/42976/3//COMMIT_MSG@7
PS3, Line 7: Configs: Set PCH power policy register to S5
The commit message does not match the change in this patchset
Suggest change title to:
/mb/ocp/deltalake: disable MAINBOARD_POWER_FAILURE_STATE
Might update rest of comment.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42976
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4d4f14bdfc18740976171fd5d369b2d79a916dc4
Gerrit-Change-Number: 42976
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Bryant Ou
bryant.ou.q@gmail.com
Gerrit-CC: Frans Hendriks
fhendriks@eltan.com
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-CC: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-CC: Rocky Phagura
Gerrit-CC: Ryback Hung
ryback.hung%quantatw.com@gtempaccount.com
Gerrit-Comment-Date: Tue, 07 Jul 2020 13:12:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment