Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44634 )
Change subject: mb/google/zork: support custom WiFi SAR for morphius ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44634/3/src/mainboard/google/zork/K... File src/mainboard/google/zork/Kconfig:
https://review.coreboot.org/c/coreboot/+/44634/3/src/mainboard/google/zork/K... PS3, Line 260: bool "Enable SAR options for Chrome OS build"
By not making things default to 'y' would follow how hatch and drallion implemented it. […]
Looks like you have what I suggested covered. I suggest you remove the WIFI_SAR_CBFS option below and the "help string" then this patch will build. However, please update the code in src/vendorcode/google/chromeos/sar.c as I suggested in a separate patch. With that I think it'll all work.