Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43843 )
Change subject: soc/skylake: Enable SATA depending on devicetree configuration
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/43843/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/43843/3//COMMIT_MSG@9
PS3, Line 9: but this is
: duplicate to the devicetree on/off options
… this is a duplicate of …
Maybe just use the verb:
… this duplicates the devicetree on/off options.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43843
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I217dcb7178f29bbdeada54bdb774166126b47a5a
Gerrit-Change-Number: 43843
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: Wim Vervoorn
wvervoorn@eltan.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 25 Jul 2020 07:17:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment