Attention is currently required from: Damien Zammit, Edward O'Callaghan, Angel Pons.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62759 )
Change subject: hp/z220_cmt_workstation: Add variant of z220_sff_workstation
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/hp/z220_sff_workstation/variants/z220_cmt_workstation/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/62759/comment/49d133ee_741c8085
PS2, Line 18: 0xa00
That decode address does not seem to be set up in genX_dec. There is no real reason to override it, so I'd just remove it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62759
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I187dba9d9332aa3a8ee9207fc224a7d87da22c6f
Gerrit-Change-Number: 62759
Gerrit-PatchSet: 2
Gerrit-Owner: Damien Zammit
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Damien Zammit
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Tue, 15 Mar 2022 07:46:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment