Attention is currently required from: Martin L Roth, Raul Rangel, Rob Barnes.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76188?usp=email )
Change subject: util/apcb: Add apcb edit tool for phoenix
......................................................................
Patch Set 2:
(1 comment)
File util/apcb/apcb_v3a_edit.py:
https://review.coreboot.org/c/coreboot/+/76188/comment/ed53e5aa_7a0e98c1 :
PS2, Line 45: 16
APCB_CHECKSUM_OFFSET instead of magic 16 and APCB_CHECKSUM_OFFSET + 1 for magic 17
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76188?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifb50287de77138170714a702ab87d56427aacfef
Gerrit-Change-Number: 76188
Gerrit-PatchSet: 2
Gerrit-Owner: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Rob Barnes
robbarnes@google.com
Gerrit-Comment-Date: Fri, 30 Jun 2023 21:49:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment