Attention is currently required from: Tony Huang.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/82035?usp=email )
Change subject: mb/google/rex/var/deku: Configure GPIO
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/82035/comment/43e2705e_984c6c42 :
PS2, Line 7: Configure GPIO
The text below would have been the better, as more specific, summary.
https://review.coreboot.org/c/coreboot/+/82035/comment/45bd8f4e_7308f568 :
PS2, Line 9: Set unused pin to NC internal PU 20K
Would be nice, if you elaborated next time. Was the board design updated?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82035?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I78eddaa41c14721eeb6ff33a4cb15382853e430b
Gerrit-Change-Number: 82035
Gerrit-PatchSet: 2
Gerrit-Owner: Tony Huang
tony-huang@quanta.corp-partner.google.com
Gerrit-Reviewer: Curtis Chen
curtis.chen@intel.corp-partner.google.com
Gerrit-Reviewer: Derek Huang
derekhuang@google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jakub Czapiga
czapiga@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Robert Chen
robert.chen@quanta.corp-partner.google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun
tstuli@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kevin Chiu
kevin.chiu@quanta.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tony Huang
tony-huang@quanta.corp-partner.google.com
Gerrit-Comment-Date: Tue, 23 Apr 2024 20:37:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment