Attention is currently required from: YH Lin, Tarun Tuli, Subrata Banik, Daniel Rosa Franzini, Kapil Porwal.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74257 )
Change subject: mb/google/rex: add variant gpio tables for variant creation
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
@YH, let's put the gpio.c and make file to util/mainboard/google/rex0/template/ then you don't need const struct pad_config *variant_gpio_override_table(size_t *num), that's more fit the current design.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74257
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iebc098f8d480ac3e1835b00861fd844d97f281a8
Gerrit-Change-Number: 74257
Gerrit-PatchSet: 4
Gerrit-Owner: YH Lin
yueherngl@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Daniel Rosa Franzini
danielt3@usp.br
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: YH Lin
yueherngl@google.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Daniel Rosa Franzini
danielt3@usp.br
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Comment-Date: Wed, 12 Apr 2023 01:19:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment