Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31685 )
Change subject: device/pci_ops: Reuse romstage PCI config for ramstage ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/31685/4/src/include/device/pci_type.h File src/include/device/pci_type.h:
https://review.coreboot.org/#/c/31685/4/src/include/device/pci_type.h@29 PS4, Line 29: #define PCI_BDF(dev) pcidev_assert((dev))
Why the macro? Why not just name the function pcidev_bdf()?
We have those pesky NULL pointers from dev_find_slot() on amdfam.
My plan is to have some debugging with PCI_BDF(dev) expanding to some printk using __func__, __line__ to catch those. Has to be done with preprocessor, right?