[coreboot-gerrit] [L] Change in coreboot[master]: util/cbmem: add parsing of TPM logs per specs

[Sergii Dmytruk (Code Review)]

Attention is currently required from: Arthur Heymans, Benjamin Doron, Christian Walter, Felix Held, Himanshu Sahdev, Julius Werner, Maximilian Brune, Michał Kopeć, Michał Żygowski.

Sergii Dmytruk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68749?usp=email )

Change subject: util/cbmem: add parsing of TPM logs per specs
......................................................................

Patch Set 22:

(1 comment)

File util/cbmem/cbmem.c:

https://review.coreboot.org/c/coreboot/+/68749/comment/35a9c54e_6e419175 :
PS22, Line 961: 			die("Unknown hash algorithm\n");
> is it necessary to call die() here or would printing an error (and telling the caller that something […]

I think in a user-space utility like `cbmem` dying can always be avoided and is used just a shorthand for `puts()`+`exit(1)` with a familiar name.  Changing that will probably require updating most functions to communicate error condition.

In this particular case parsing must be stopped because log entries don't contain hash size, they contain hash type from which the code infers the size, thus unknown type prevents further parsing.