[coreboot-gerrit] Change in coreboot[master]: mb/google/volteer: Add gpio-keys ACPI node for PENH

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43764 )

Change subject: mb/google/volteer: Add gpio-keys ACPI node for PENH
......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43764/5/src/mainboard/google/voltee... 
File src/mainboard/google/volteer/variants/volteer/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/43764/5/src/mainboard/google/voltee... 
PS5, Line 74: EDGE_BOTH
> Looks like I was out of date, gpiolib seems to use this field directly to setup the irqflags: […]

Thanks for the pointer. I don't think we would ever make it that far in that function though, there is no _Exx or _Lxx method nor an _EVT method for the GPIO controller, so it should bail on line 290 in that file instead? There is also no `_AEI` method indicating that OSPM is supposed to handle this event (via `_Exx` or `_Lxx`), so doesn't all of this info just trickle down to the device driver? Or am I misunderstanding section 5.6 of the ACPI spec?