Attention is currently required from: Francois Toguo Fotso, Paul Menzel, Curtis Chen, Patrick Rudolph.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59951 )
Change subject: soc/intel/common: Do not trigger crashlog on all resets by default
......................................................................
Patch Set 6:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59951/comment/44170b99_b04faa88
PS1, Line 13: apreset
suggestion: […]
Done
File src/soc/intel/common/Kconfig.common:
https://review.coreboot.org/c/coreboot/+/59951/comment/c538f38c_20ae8ac0
PS4, Line 87: CrashLog
nit: […]
Done
https://review.coreboot.org/c/coreboot/+/59951/comment/dfa8cc6f_085d79be
PS4, Line 92: Enable PMC reset crashlog record.
suggestion: […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59951
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3ec4ff3c8a3799156de030f4556fe6ce61305139
Gerrit-Change-Number: 59951
Gerrit-PatchSet: 6
Gerrit-Owner: Curtis Chen
curtis.chen@intel.com
Gerrit-Reviewer: Francois Toguo Fotso
francois.toguo.fotso@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kane Chen
kane.chen@intel.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Francois Toguo Fotso
francois.toguo.fotso@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Curtis Chen
curtis.chen@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Thu, 16 Dec 2021 22:39:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Curtis Chen
curtis.chen@intel.com
Gerrit-MessageType: comment