Attention is currently required from: Angel Pons, Annie Chen, Arthur Heymans, David Hendricks, Lean Sheng Tan, Paul Menzel.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75598?usp=email )
Change subject: mb/inventec: Add Intel SPR server board Inventec Transformers
......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS5:
I compared both mainboards, ArcherCity CRB and yours, and most of it is actually the same. I am wondering if adding a variant to ArcherCity makes more sense.
Basically, this means that both mainboards live in the same folder (which is intel/archercity_crb) and the common code is shared. The mainboard specific code and files go to a variant folder. There are many examples in the tree if you want to have a look at it.
What do you think?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75598?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic9d99c3aadaa9f69e6d14d4b1a6c5157f5590684
Gerrit-Change-Number: 75598
Gerrit-PatchSet: 5
Gerrit-Owner: Annie Chen
chen.annieet@inventec.com
Gerrit-Reviewer: Angel Pons
angel.pons@9elements.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Hung-Wei Chen
Chen.HW@inventec.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Annie Chen
chen.annieet@inventec.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: David Hendricks
david.hendricks@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Angel Pons
angel.pons@9elements.com
Gerrit-Comment-Date: Wed, 07 Jun 2023 03:17:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment