Wim Vervoorn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41695 )
Change subject: [WIP] arch/x86: Remove C_ENV_BOOTBLOCK_SIZE
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41695/2/src/southbridge/intel/i8237...
File src/southbridge/intel/i82371eb/bootblock.c:
https://review.coreboot.org/c/coreboot/+/41695/2/src/southbridge/intel/i8237...
PS2, Line 28: */
The bootblock on systems with i82371eb is currently just over 4 KiB, if it grows over 64 KiB some bu […]
Your right and I guess the main use for this code is the qemu support. A "bricked" qemu isn't a big issue anyhow.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41695
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib1aee44908c0dcbc17978d3ee53bd05a6200410c
Gerrit-Change-Number: 41695
Gerrit-PatchSet: 2
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: Wim Vervoorn
wvervoorn@eltan.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 28 May 2020 10:10:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Comment-In-Reply-To: Wim Vervoorn
wvervoorn@eltan.com
Gerrit-MessageType: comment